Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rem units instead of pixels #102

Closed
endymion1818 opened this issue Sep 18, 2019 · 1 comment
Closed

Use rem units instead of pixels #102

endymion1818 opened this issue Sep 18, 2019 · 1 comment

Comments

@endymion1818
Copy link
Contributor

What
We currently use pixels for all units in react-components. I think it would be good to consider the possibility of using rems instead, although it might not be possible at this stage ...

Why
Predominantly, Zopa apps use pixels. The react-components library has been built to integrate with these apps efficiently by using pixels too. But there are some issues when using pixels: some people who have sight issues will not be able to zoom the interface, and pixel sizes differ from screen to screen, resulting in inconsistent experiences.

Should we at some point switch to using using REMs? What are the considerations?

Relevant documentation:
https://stackoverflow.com/questions/11799236/should-i-use-px-or-rem-value-units-in-my-css

https://twitter.com/heydonworks/status/1151443153657958405?s=11

https://every-layout.dev/rudiments/units/

@endymion1818
Copy link
Contributor Author

Closing after discussions with the team; it seems that pixels are used in every other app; introducing rems would unnecessarily complicate things for those apps.

I think we should revisit this at a chapter level soon, I don't think we should risk limiting or blocking any of our users even if it means inconvenience for ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant