Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPy Support: Interest and Feasibility #3

Closed
jamadden opened this issue Mar 18, 2015 · 4 comments
Closed

PyPy Support: Interest and Feasibility #3

jamadden opened this issue Mar 18, 2015 · 4 comments
Labels

Comments

@jamadden
Copy link
Member

We have a project we're interested in running on PyPy, and one of our current blockers for that is Acquisition. Our project doesn't use all the features of Acquisition and I'm not an Acquisition expert, but as I started noodling around with it over at https://github.com/Nextthought/Acquisition, it started to seem like it should be possible to implement almost all of Acquisition in pure Python in a similar fashion to zope.proxy. (A few hours work has about half the test cases passing, although this does seem like a clear place where the 80/20 rule applies.)

I think I have the time to work on such a port now, but before I get too much further I wanted to see if there was any community interest in such a port, and whether such a port is likely to get reviewed/merged. If there is, I'll press ahead with trying to make as complete an implementation as possible (although I'm sure I'll have some questions first), otherwise I'll just focus on small stubs for the things I know our project needs. Of course, if someone already knows of reasons why a port is doomed to failure (I didn't find much traffic about the topic via Google), I'd appreciate hearing that too :)

@tseaver
Copy link
Member

tseaver commented Mar 18, 2015

I would certainly be willing to review a PR which made Acquisition usable on PyPy. Be sure to add it to setup.py (the Trove classifier), and tox.ini / .travis.yml (to ensure that it doesn't regress).

Also, if you are not already a ZopeFoundation contributor, please do the dance to become one (you can list me as the "reference contributor").

@davisagli
Copy link
Member

I would also be willing to review this.

@jamadden
Copy link
Member Author

Closed with #4

@tseaver
Copy link
Member

tseaver commented Mar 19, 2015

For future reference, add the following to the commit message of one of the commits in your PR:

Closes: #123

And then leave the bug open: It will be closed automagically when the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants