Show Python Script source code in tracebacks #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests depend on zopefoundation/zope.exceptions#33 because zope.testrunner monkey patches |
perrinjerome
commented
May 24, 2024
| @@ -261,6 +273,7 @@ def _compile(self): | |||
| fc.co_argcount) | |||
| self.Python_magic = Python_magic | |||
| self.Script_magic = Script_magic | |||
| linecache.clearcache() | |||
There was a problem hiding this comment.
this empties all the cache, which will cause the next use of linecache to take a few milliseconds. In practice it's also possible to only remove the corresponding entry from the cache, like this:
linecache.cache.pop(
getattr(self, '_filepath', None) or self.get_filepath(), None)but it's not a documented API and this is only called when python scripts are edited, so I thought it was better to just clear all the cache.
perrinjerome
force-pushed
the
perrinjerome/code-in-traceback
branch
from
90db8df
to
ec0214d
Compare
Expose a __loader__ in globals so that linecache module is able to use it to display the source code. This requires changing the "filename" used when compiling function, because linecache uses code.co_filename as a cache key, so it's necessary that each python script use a different filename.
perrinjerome
force-pushed
the
perrinjerome/code-in-traceback
branch
from
ec0214d
to
c0f2bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a
__loader__in globals so that linecache module is able to use it to display the source code.This requires changing the "filename" used when compiling function, because linecache uses code.co_filename as a cache key, so it's necessary that each python script use a different filename.
Fixes #64