-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit PyPy Support (in progress) #33
Comments
As of now, the The functional tests still have some issues. I'm guessing those are mostly refcounting/GC related. I'll look into those next. |
Update: All 482 functional tests now run under PyPy using those branches. |
With the |
@jamadden branch of persistent has been merged and released as 4.0.9 |
@gotcha We are waiting on zopefoundation/persistent#20 to be merged and released as 4.0.10. |
I've just doint a review of zopefoundation/persistent#20 |
@tseaver Thank you! I know there's a lot to review there. The PRs for ZODB and ZEO are (currently) much smaller. |
I don't see a PR for ZEO. |
Actually, I don't see one for ZODB, either: are both pending landing zopefoundation/persistent#20? |
Yes. I could open them now, but they would fail all the Travis tests until that PR gets merged and released. I should have been more specific about the "forthcoming PRs". |
ZODB currently does not cleanly pass a test run under PyPy --- there are numerous failures.
Part of this is due to the lack of
noload
in PyPy's "cPickle" module (which is actually implemented in Python) --- this is easily solved through the use ofzodbpickle
(which is already a dependency). At least part of the rest of it is due to differences in the C and pure-Python implementations ofpersistent
(e.g., the PythonPickleCache
lacks some size attributes found in the C version).Hopefully the rest are minor differences, but I'm not sure yet. I'm working on a branch at https://github.com/NextThought/ZODB/tree/pypy to find out, and hopefully fix them (looks like some other PRs in
persistent
will be useful, too).I'm opening this issue to let people know someone is working on this, and maybe to have a place to ask for help if I get stuck :)
The text was updated successfully, but these errors were encountered: