Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CSS classes functionnality more efficient #2

Open
gbastien opened this issue May 28, 2015 · 0 comments
Open

Make CSS classes functionnality more efficient #2

gbastien opened this issue May 28, 2015 · 0 comments

Comments

@gbastien
Copy link
Member

Hi @jfroche @mgedmin @alga

from what I can see for now, as it, it is not possible for example to define a CSS class to apply to a particular row, am I wrong? I see that it is possible to define on the table cssClasses attribute some fixed CSS class for "tr", but nothing more?

What we try to achieve is, for some item displayed in the table, to display them in the table differently by highlighting the row, using a CSS class on it. I think this is not possible for now...

To me it is not possible to generate this :

<table>
<tr><td></td><td class="classForThisTdOnly"></td></tr>
<tr><td></td><td></td></tr>
</table>

This neither:

<table>
<tr class="classForThisTrOnly"><td></td><td></td></tr>
<tr><td></td><td></td></tr>
</table>

What I would like to PR is :

  • change the cssClasses attribute by a getCSSClasses method receiving the item so it is much more powerfull and possible to generate the CSS class to use for a TR or a TD;
  • make it possible to define on a column, a CSS class to use for the TR.

Does that seem ok? I will try to stay backward compatible with the cssClasses attribute by making the getCSSClasses method returns the content of this attribute by default.

Any hints?

Thank you,

Gauthier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant