Fix build and all deprecation warnings on Python 3. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zopyx#10. This updates the package to use the new-in-Python-3 unicode APIs when available.
|
travis-ci.org is shutting down so there's currently no CI running on PRs here. I have tested it locally with Python 2.7, 3.5 and 3.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
This updates the package to use the new-in-Python-3 unicode APIs when available. Previously there were ~50 deprecation warnings. Now there are none.
This also converts most uses of
size_tintoPy_ssize_t, because that's what the Python APIs use and return (e.g., for unicode length, sequence length, etc). This eliminates more warnings and casts.