Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load chat before entering a username #17

Closed
zorchenhimer opened this issue Mar 11, 2019 · 2 comments
Closed

Load chat before entering a username #17

zorchenhimer opened this issue Mar 11, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request front-end Anything HTML/CSS/JS

Comments

@zorchenhimer
Copy link
Owner

Load and display chat before the user enters a username. Instead of showing the message box at the bottom, show the "Enter Username" input.

Wait until after #4 is finished to implement this.

@zorchenhimer zorchenhimer added enhancement New feature or request front-end Anything HTML/CSS/JS labels Mar 11, 2019
@joeyak
Copy link
Collaborator

joeyak commented Mar 11, 2019

In #4, I might implement part of this. Having the connection join when the page loads simplifies things and might solve a problem with goroutine deadlocks I was having. What I will not do in #4 is changing the UI for inputting their name.

@joeyak
Copy link
Collaborator

joeyak commented Mar 11, 2019

After looking at the chatroom code, I'll leave that area alone, since the changes are much larger. The websocket will open on page join instead of when the user presses join.

@joeyak joeyak added this to To do in Features and TODOs via automation Mar 13, 2019
@joeyak joeyak self-assigned this Mar 13, 2019
@joeyak joeyak moved this from To do to In progress in Features and TODOs Mar 13, 2019
@joeyak joeyak closed this as completed in 5516313 Mar 13, 2019
Features and TODOs automation moved this from In progress to Done Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front-end Anything HTML/CSS/JS
Projects
Development

No branches or pull requests

2 participants