New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The problem in PHP8 #348
Comments
This is also helping for me. I'm also on php 8. Not sure if it is the right way to go, I hope we get some feedback on that. CRITICAL: Uncaught Exception ParseError: "syntax error, unexpected token ","" at /tmp/lci_Z3NgN8 line 14 {"exception":"[object] (ParseError(code: 0): syntax error, unexpected token "," at /tmp/lci_Z3NgN8:14)"} |
My fix. Not tested enough yet: yurikuzn@207d424 |
I actually came across this and ended up doing the same thing you did. The problem is the change isn't backwards compatible. |
Just tried out the above fix yurikuzn/lightncandy@207d424 |
Works for me, too. Can you make a PR from this @yurikuzn ? |
Done: #351 |
@yurikuzn's approach is more compatible than mine. so, we can close this issue. |
This issue has appeared after upgrading to PHP8.
I did a search and found the problem and I made a change in this file;
./src/vendor/lightncandy/Exporter.php
Is this a correct way to fix it?
The text was updated successfully, but these errors were encountered: