Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin actions cannot be confirmed as there is no password to confirm #343

Closed
davidc opened this issue Mar 25, 2022 · 3 comments
Closed

Admin actions cannot be confirmed as there is no password to confirm #343

davidc opened this issue Mar 25, 2022 · 3 comments

Comments

@davidc
Copy link

davidc commented Mar 25, 2022

After being idle for a while, making changes to the settings in the admin site require password confirmation: "This action requires you to confirm your password".

Obviously this is impossible for users on this backend as there is no way to confirm their SSO password.

The relevant code appears to be here: https://github.com/nextcloud/server/blob/0d0fcd316a6b556cabf656cd7bdca63da26aab2d/lib/private/Template/JSConfigHelper.php#L123

It seems they have a hardwired list of backends to exclude from this confirmation, of which nextcloud-social-login is not one. The solution may be to implement IPasswordConfirmationBackend and have canConfirmPassword() always return false, but I don't know what other effects this may have.

@zorn-v
Copy link
Owner

zorn-v commented Mar 26, 2022

I can understand "what you don't like" )
Users that created via social login doesn not know their passwords.
They should be to have opportunity to change it.

@davidc
Copy link
Author

davidc commented Mar 26, 2022

The entire point of SSO is that they have one password at the IdP - single sign on.

Making them create a Nextcloud password as well defeats the object. Why even bother with SSO then? We might as well just create users and have them do password resets. And then they have to maintain another password. So why did we implement SSO?

@zorn-v
Copy link
Owner

zorn-v commented Mar 26, 2022

The entire point of SSO is that they have one password at the IdP - single sign on.

Where you can find that my app is for SSO ?
Yes, it can resolve some SSO "problems", but it not for it.

@zorn-v zorn-v closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants