Pass env_proxy opts to Furl #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could use better tests, but I couldn't figure out how to have an AnyEvent::Socket listening during $rtm->start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could use better tests, but I couldn't figure out how to have an AnyEvent::Socket listening during $rtm->start.
This should resolve #10 by calling env_proxy if that was one of the opts passed to the constructor. It didn't seem worthwhile to have separate options for both of these.
This does pull in the newer AnyEvent::WebSocket::Client that has support for env_proxy as well, but that was mostly needed to make sure the tests passed.