New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Deprecation warning in Django 1.9 #297
Conversation
@dyve any reason not to merge this? would be nice to get rid of the warnings in test logs. Hmm, I see I have some pieces commented out, let me fix that. |
about first param to `template.render`: ``` /home/jieter/.virtualenvs/bootstrap/local/lib/python2.7/site-packages/bootstrap3/utils.py:142: RemovedInDjango110Warning: render() must be called with a dict, not a Context. return template.render(Context(context)) ```
Just that I'm currently very busy. This looks OK to me, and if Travis agrees I'll pull it in. |
Fix Deprecation warning in Django 1.9
Thanks! |
It looks like the fix has a bug, and that the Django 1.9 docs still advise to use Context. I don't understand the warning when the docs say: |
There seems to a difference between templates coming from "If context is provided, it must be a dict. If it isn’t provided, the engine will render the template with an empty context." |
Let me see if I can work with that.
|
Stumped
|
|
@jieter Are we missing something or did this change/warning somehow got bugged in 1.9.2? |
Same in 1.9.1 |
about first param to
template.render
:Let's see if this works better than my try in #292.