-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wikimedia Commons: Image file doesn't attach #3136
Comments
@zoe-translates: Apparently this translator still uses FW - any interest in rewriting? |
This is the most recently-updated translator that still relies on FW. I'm going to stop that :) One question about downloading the images themselves - Some files hosted by the Wikimedia Commons could be super large. Should we impose an upper-limit on the attachment's file size, above which the file is saved as a link ( |
Sure. 10 MB? |
In fact, the reported problem was caused by the xpath here (and the second appearance on line 121: translators/Wikimedia Commons.js Lines 85 to 88 in 8e5c648
The xpath However there are a lot more problems with this translator that I'm unwilling to submit just this change of xpath as a hotfix (it won't actually "fix" anything, because the other metadata fields are still broken, and the attachment itself misses So I think this is an opportunity to re-write the translator. |
Todo:
|
Example: https://commons.wikimedia.org/wiki/File:Baryon_decuplet.png
Reported: https://forums.zotero.org/discussion/107766/unable-to-download-file-from-wikiedia-commons#latest
To be clear: the metadata imports fine, as does the snapshot, by the translator is supposed to also download the image on the page, which it doesn't anymore.
I haven't looked at this in any more detail, but wouldn't be surprising if Commons changed how image files are made available.
The text was updated successfully, but these errors were encountered: