Don't send translator error reports in private-browsing mode

[dstillman]

There's existing code to prevent this for Zotero for Firefox, but we should update that for the connector.

This is deep in the translation architecture, so the best way to do this is probably to include a flag in the object passed to translate() to indicate that a report shouldn't be sent on failure.

[adomasven]

This is deep in the translation architecture, so the best way to do this is probably to include a flag in the object passed to translate() to indicate that a report shouldn't be sent on failure.

There's already a pref controlling this though and at least for the client that's the only way of control. I'm happy to just add the handling code for extensions there. Thoughts?

[dstillman]

That pref isn't really relevant. This is specific to private browsing, and is just a reimplementation of the existing protection we've always had in Zotero for Firefox. Extensions shouldn't upload URLs from private browsing with default settings.

What do you mean by "at least for the client that's the only way of control"? This is just for the connector.

[adomasven]

This is a question regarding adding a flag to be passed to translate(). So we'd have translate.reportTranslationFailures flag that had been passed in via translate() and the pref, which is confusing. I propose to just add the incognito check there in translate.js.

[dstillman]

Ah, I see what you mean. I was assuming we might not have easy access to the incognito check at the point of the existing code. If we do, that's fine. If not, I figured we could have a skipFailureReporting or something at the point of the translate() call, and that would disable reporting even if the pref was on.

[adomasven]

Closed with 0192bda