Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTF insertion on macOS does not work #35

Closed
adomasven opened this issue Jan 15, 2018 · 7 comments
Closed

RTF insertion on macOS does not work #35

adomasven opened this issue Jan 15, 2018 · 7 comments

Comments

@adomasven
Copy link
Member

LO 5.3.0.3, macOS 10.13.2

@adomasven
Copy link
Member Author

Cannot reproduce after updating extension in LO to 5.0.8

@dstillman
Copy link
Member

dstillman commented Jan 15, 2018

I'm still seeing this with 5.0.8. Was happening in 5.3, still happening in 5.4.4.2.

The properly formatted version appears initially (maybe without a gray background?) and then is immediately replaced by a field with a gray background and no formatting.

  1. Add a citation in Chicago, ReferenceMarks.
  2. Click on the citation and choose Add/Edit.
  3. Open Classic View, Show Editor
  4. Add italics to a word in the citation

The italics don't appear in the document. If you return to the editor, the formatting is still set.

@adomasven
Copy link
Member Author

This is just the editor styling not actually functioning. It produces HTML formatting, but all of our plugins use RTF.

@dstillman
Copy link
Member

If it's not functioning, why am I briefly seeing the correct formatting in LibreOffice, and why did it just appear when I clicked Refresh a couple times?

Let's leave this open until this is resolved.

@dstillman dstillman reopened this Jan 15, 2018
@dstillman
Copy link
Member

  1. Add a citation in Chicago, ReferenceMarks.
  2. Click on the citation and choose Add/Edit.
  3. Open Classic View, Show Editor
  4. Add an underline to a word in the citation and click OK.

The underline doesn't appear for me in LibreOffice.

However:

  1. Click Refresh

I briefly see the underline, and then it goes away again.

  1. Click Refresh again.

The underline reappears and stays put.

@adomasven
Copy link
Member Author

adomasven commented Jan 16, 2018

Ok. Should have got the sleep before looking into this:

  • Custom citation code is broken in Refactor integration and delay citation updates zotero#1242 . To be fixed.
  • Custom citations work fine on master with all word processors. HTML -> RTF conversion done by styled-textbox
  • There's a caveat for LibreOffice plugin, where partial inline citation styling disappears and only styling applied to the whole chunk of text applies. This is due to an optimization, which speeds up inline citation updates for libreoffice 2x. I'm not in favor of reverting this until someone on the forums comes with a very compelling argument for why partial custom styling of inline citations is that important

Inclined to close this.

@adomasven
Copy link
Member Author

Closing this since I don't see us slowing down the LO plugin to facilitate an extreme corner case and there has been no discussion re this for 2 years on the forums or anywhere else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants