Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PMID extraction stricter #1378

Closed
dstillman opened this issue Nov 29, 2017 · 3 comments
Closed

Make PMID extraction stricter #1378

dstillman opened this issue Nov 29, 2017 · 3 comments

Comments

@dstillman
Copy link
Member

https://forums.zotero.org/discussion/69134/will-add-by-identifier-gobble-up-anything-and-output-random-new-items

@dstillman
Copy link
Member Author

Still need to fix this. We shouldn't be matching on numbers bounded by hyphens.

https://forums.zotero.org/discussion/71740/usurp-isbn

@mrtcode
Copy link
Member

mrtcode commented May 7, 2018

The current PMID matcher is very permissive - extracts numbers separated by non-digit characters i.e. from a1%2g3 it extracts 1,2,3. I think we should only allow commas and spaces between PMID identifiers.

@dstillman
Copy link
Member Author

Yeah, I agree with that. (Should be whitespace generally, so that you can paste multiple PMIDs separated by newlines.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants