Allow item pane sections to declare dependencies for rerender, fix Libraries and Collections not updating #4155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
|
Does that still look OK? I realized that we'd be better off not relying on string comparison for this. |
windingwind
reviewed
May 25, 2024
The Feed field hides/shows depending on collection tree row.
AbeJellinek
force-pushed
the
4154-rerender-when-switching-collections
branch
from
054967b
to
1fbcd35
Compare
|
How's that? Should avoid naming confusion and test breakage. |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
The item pane header seems to be broken for me. The relevant tests fail and changes to the header mode are not applied until the next restart. |
|
Oh, right, thanks - fixed! |
|
Thanks for the quick fix. Seems nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collectionTreeRowdown to item pane sectionsFixes #4154