core: Improve log messages consistency #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
changed the title
ddeboer
commented
Nov 10, 2016
| @@ -31,7 +31,7 @@ | |||
| {lager, | |||
| [{handlers, | |||
| [ | |||
| {lager_console_backend, info}, | |||
| {lager_console_backend, [info, {lager_default_formatter, [time, " [", severity, "] ", {site, [site, " "], ""}, {module, [module, ":", line, " "], ""}, message, "\n"]}]}, | |||
There was a problem hiding this comment.
Using Logstash conditional formatting.
ddeboer
changed the title
ddeboer
force-pushed
the
1507-simplify-logging
branch
4 times, most recently
from
927297c
to
20f1c43
Compare
|
@mworrell Please review. |
ddeboer
commented
Nov 15, 2016
| {lager_console_backend, info}, | ||
| {lager_file_backend, [{file, "priv/log/error.log"}, {level, error}]}, | ||
| {lager_console_backend, [info, {lager_default_formatter, [time, " [", severity, "] ", {site, [site, " "], ""}, {module, [module, ":", line, " "], ""}, message, "\n"]}]}, | ||
| {lager_file_backend, [{file, "priv/log/error.log"}, {level, error}, {formatter, lager_default_formatter}]}, |
There was a problem hiding this comment.
Todo: check how this influences error.log output. We want lager metadata in error|console.log too.
ddeboer
force-pushed
the
1507-simplify-logging
branch
from
20f1c43
to
b26d9c3
Compare
* Call lager functions directly so parse transform works. * Remove usage of lager:log, which bypasses parse transform. * Remove all custom message formatting: have one standard in the lager configuration.
ddeboer
force-pushed
the
1507-simplify-logging
branch
from
b26d9c3
to
297eb9d
Compare
ddeboer
added a commit
that referenced
this pull request
Nov 15, 2016
* Call lager functions directly so parse transform works. * Remove usage of lager:log, which bypasses parse transform. * Remove all custom message formatting: have one standard in the lager configuration. (cherry picked from commit cb8ccb1)
ddeboer
added a commit
that referenced
this pull request
Nov 15, 2016
* Call lager functions directly so parse transform works. * Remove usage of lager:log, which bypasses parse transform. * Remove all custom message formatting: have one standard in the lager configuration. (cherry picked from commit cb8ccb1)
1 task
ddeboer
added a commit
that referenced
this pull request
Nov 23, 2016
* Fix lager:error calls throwing a FORMAT ERROR due to invalid number of parameters. * Remove site name from log messages (see also #1510).
mworrell
pushed a commit
that referenced
this pull request
Nov 29, 2016
* Fix lager:error calls throwing a FORMAT ERROR due to invalid number of parameters. * Remove site name from log messages (see also #1510).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1507.
error.logandconsole.log:Checklist