core: Read erlang.config in sitetest command #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @arjan. |
arjan
approved these changes
May 9, 2017
ddeboer
added a commit
that referenced
this pull request
May 9, 2017
(cherry picked from commit 2c8148a)
ddeboer
added a commit
to ddeboer/zotonic
that referenced
this pull request
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
zotonic sitetestcommand didn’t readerlang.config. This PR addserlang.configto the sitetest arguments. This solves configuration differences between live and test, which caused some of our tests to fail.@arjan Did you ignore
erlang.configon purpose? It seems that we can add it without problems.Checklist