Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New zotonic release causes unnessary recompilations #1842

Closed
mmzeeman opened this issue Nov 8, 2017 · 2 comments · Fixed by #1844
Closed

New zotonic release causes unnessary recompilations #1842

mmzeeman opened this issue Nov 8, 2017 · 2 comments · Fixed by #1844
Labels
core enhancement

Comments

@mmzeeman
Copy link
Member

mmzeeman commented Nov 8, 2017

When we bump the version number of zotonic we update zotonic.hrl. This causes a recompilation of all code which is not nice when you do live code upgrades.

Could we move the version number to a separate header file?
@ddeboer
Copy link
Member

ddeboer commented Nov 8, 2017

Or just remove it? Where is it used, anyway? Only for the HTTP responses?

@mworrell
Copy link
Member

mworrell commented Nov 8, 2017

See 2360411

Now also changing it for master (will be merge request)

Accompanying merge request for mod_github:
arjan/mod_github#5

@mworrell mworrell mentioned this issue Nov 8, 2017
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove include of zotonic_version.hrl from zotonic.hrl. zotonic/zotonic
3 participants
@mworrell @ddeboer @mmzeeman