fix: Load balancer remote cache bugs #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jandadav <janda.david@gmail.com>
Signed-off-by: jandadav <janda.david@gmail.com>
Signed-off-by: jandadav <janda.david@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
balhar-jakub
approved these changes
Jul 26, 2021
gateway-service/src/main/java/org/zowe/apiml/gateway/cache/LoadBalancerCache.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix several bugs and some refactors to make the remote cache behave consistently
Description of the bugs
When cache record exists locally but not on remote, the check in post-store filter (whether the instance is already cached) returned true (local) cache and remote cache was never updated.
Another one is when cache is stored locally, and then retrieved from remote, then inconsistent behavior happens when remote disappears or fails. The stores to local never happens.
Another bug is that cache record did never get updated thanks to 409 Conflict from caching service. This led to cache record never updating and expiring after 8 hours since "first" usage, and not the "last" usage.
Linked to #1412