Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add stomp v1.2 as supported protocol #1697

Merged
merged 5 commits into from Aug 12, 2021
Merged

fix: add stomp v1.2 as supported protocol #1697

merged 5 commits into from Aug 12, 2021

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Aug 12, 2021

Signed-off-by: achmelo a.chmelo@gmail.com

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to #1691

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@achmelo
add stomp v1.2 as supported protocol
80ffddf 
Signed-off-by: achmelo <a.chmelo@gmail.com>
@achmelo
remove old classes from test
128692c 
Signed-off-by: achmelo <a.chmelo@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 12, 2021
@achmelo
exclude ciphers, remove jetty server config
b02a715 
Signed-off-by: achmelo <a.chmelo@gmail.com>
@achmelo
configurable subprotocol list
2b4d455 
Signed-off-by: achmelo <a.chmelo@gmail.com>
@achmelo
default value
720ed3b 
Signed-off-by: achmelo <a.chmelo@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@achmelo achmelo merged commit d1057e0 into master Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the rip/gh1691/ws-subprotocols branch August 12, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balhar-jakub balhar-jakub balhar-jakub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achmelo @balhar-jakub