feat: Per service configuration to ignore certain headers #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: Carson Cook <carson.cook@ibm.com>
|
Code smell is due to code duplication, the duplication is boiler plate |
jandadav
requested changes
Sep 29, 2021
gateway-service/src/main/java/org/zowe/apiml/gateway/routing/RouteUtil.java
Outdated
Show resolved
Hide resolved
...tests/src/test/java/org/zowe/apiml/integration/proxy/GatewayPerServiceIgnoreHeadersTest.java
Outdated
Show resolved
Hide resolved
...y-service/src/main/java/org/zowe/apiml/gateway/filters/pre/PerServiceIgnoreHeaderFilter.java
Show resolved
Hide resolved
Signed-off-by: Carson Cook <carson.cook@ibm.com>
jandadav
requested changes
Sep 30, 2021
Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: Carson Cook <carson.cook@ibm.com>
CarsonCook
force-pushed
the
apiml/GH1797/perservice_ignore_headers
branch
from
1934bfe
to
bdb6ecf
Compare
|
Kudos, SonarCloud Quality Gate passed! |
jandadav
approved these changes
Oct 1, 2021
delete-merged-branch
bot
deleted the
apiml/GH1797/perservice_ignore_headers
branch
CarsonCook
added a commit
that referenced
this pull request
Oct 27, 2021
* PoC for per service ignore headers Signed-off-by: Carson Cook <carson.cook@ibm.com> * Dry code getting service instance from uri Signed-off-by: Carson Cook <carson.cook@ibm.com> * Improve filter name Signed-off-by: Carson Cook <carson.cook@ibm.com> * Add RouteUtil unit tests Signed-off-by: Carson Cook <carson.cook@ibm.com> * Add per service ignore header filter unit tests Signed-off-by: Carson Cook <carson.cook@ibm.com> * Add integration test for ignoring headers Signed-off-by: Carson Cook <carson.cook@ibm.com> * Fix proxyrequesthelper instantiation Signed-off-by: Carson Cook <carson.cook@ibm.com> * Use zuul context to get service instance Signed-off-by: Carson Cook <carson.cook@ibm.com> * Move integration test to functional test Signed-off-by: Carson Cook <carson.cook@ibm.com> * Fix mocking http client Signed-off-by: Carson Cook <carson.cook@ibm.com> * Remove formatting changes Signed-off-by: Carson Cook <carson.cook@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to add
apiml.headersToIgnorein service custom metadata to select which headers will be stripped from requests that go through the Gateway to that service.Linked to #1797
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline