Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove duplicated hystrix streams in Metrics Service dashboard #1924

Merged
merged 2 commits into from Nov 26, 2021
Merged

fix: Remove duplicated hystrix streams in Metrics Service dashboard #1924

merged 2 commits into from Nov 26, 2021

Conversation

CarsonCook
Copy link
Contributor

Signed-off-by: Carson Cook carson.cook@ibm.com

Description

Add a check such that only the hystrix streams that match the selected one to display are added in the hystrix dashboard UI.

Linked to # (issue)

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)
  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation
  • (refactor) Refactor the code
  • (chore) Chore, repository cleanup, updates the dependencies.
  • (BREAKING CHANGE or !) Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@CarsonCook
Add check for correct stream before adding
8d355bf 
Signed-off-by: Carson Cook <carson.cook@ibm.com>
@balhar-jakub
Remove logging experimental messages
0150069 
Signed-off-by: Jakub Balhar <jakub@balhar.net>
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@balhar-jakub balhar-jakub merged commit 4dfd4e1 into master Nov 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the apiml/ms_multiple_streams_displayed branch November 26, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balhar-jakub balhar-jakub balhar-jakub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CarsonCook @balhar-jakub