Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loader for extensions in custom base packages #2081

Merged
merged 17 commits into from Feb 21, 2022

Conversation

pablocarle
Copy link
Contributor

@pablocarle pablocarle commented Feb 10, 2022

Description

Linked to #1986

Implement a library for loading extensions which are defined in their own package name, it's provided as a library implementation to allow reusing in different services (for example Discovery Service and Gateway Service can use it to load these)

Based on a change to the manifest files of the extensions where if the extension defines a different base package it is scanned.
The scan is done by hooking into ApplicationContextInitializedEvent

Type of change

Please delete options that are not relevant.

  • (feat) New feature (non-breaking change which adds functionality)
  • (docs) Change in a documentation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@pablocarle pablocarle changed the title Loader for extensions in custom base packages feat: loader for extensions in custom base packages Feb 10, 2022
Pablo Hernán Carle added 10 commits February 16, 2022 15:21
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Pablo Hernán Carle added 2 commits February 17, 2022 10:20
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
@pablocarle
Copy link
Contributor Author

PR in docs-site: zowe/docs-site#2042

Pablo Hernán Carle added 2 commits February 21, 2022 10:31
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.1% 78.1% Coverage
0.0% 0.0% Duplication

@balhar-jakub
Copy link
Member

The coverage is incorrectly calculated from files we didn't touch here.

@balhar-jakub balhar-jakub merged commit 9a4be5a into v2.x.x Feb 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the extension-loader-v2 branch February 21, 2022 11:23
JirkaAichler pushed a commit that referenced this pull request Mar 7, 2022
* extensions loader

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* unit tests

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* logs

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* fix typo and fixes

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* public modifier

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* coverage

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* jupiter

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* tests

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* test

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* add case and logs

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* fix deserialization

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* remove log

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* simplify constructors

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* pr review

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

* refactor tests

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>

Co-authored-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants