New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: loader for extensions in custom base packages #2081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablocarle
changed the title
Loader for extensions in custom base packages
feat: loader for extensions in custom base packages
Feb 10, 2022
pablocarle
force-pushed
the
extension-loader-v2
branch
from
February 10, 2022 12:43
6bc4717
to
c865379
Compare
8 tasks
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
pablocarle
force-pushed
the
extension-loader-v2
branch
from
February 16, 2022 14:22
49b012b
to
3b60400
Compare
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
achmelo
reviewed
Feb 17, 2022
apiml-extension-loader/src/main/java/org/zowe/apiml/extension/ExtensionConfigReader.java
Outdated
Show resolved
Hide resolved
apiml-extension-loader/src/main/java/org/zowe/apiml/extension/ExtensionsLoader.java
Outdated
Show resolved
Hide resolved
apiml-extension-loader/src/main/java/org/zowe/apiml/extension/ZoweRuntimeEnvironment.java
Outdated
Show resolved
Hide resolved
apiml-extension-loader/src/main/java/org/zowe/apiml/extension/ZoweRuntimeEnvironment.java
Show resolved
Hide resolved
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
achmelo
approved these changes
Feb 17, 2022
PR in docs-site: zowe/docs-site#2042 |
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
… into extension-loader-v2
SonarCloud Quality Gate failed. |
The coverage is incorrectly calculated from files we didn't touch here. |
JirkaAichler
pushed a commit
that referenced
this pull request
Mar 7, 2022
* extensions loader Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * unit tests Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * logs Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * fix typo and fixes Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * public modifier Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * coverage Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * jupiter Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * tests Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * test Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * add case and logs Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * fix deserialization Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * remove log Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * simplify constructors Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * pr review Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> * refactor tests Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com> Co-authored-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked to #1986
Implement a library for loading extensions which are defined in their own package name, it's provided as a library implementation to allow reusing in different services (for example Discovery Service and Gateway Service can use it to load these)
Based on a change to the manifest files of the extensions where if the extension defines a different base package it is scanned.
The scan is done by hooking into
ApplicationContextInitializedEvent
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline