New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mitigate storing password in the memory #2858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
github-actions
bot
added
the
Sensitive
Sensitive change that requires peer review
label
Mar 31, 2023
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
…owe/api-layer into reboot/mitigateStoringPassword
JirkaAichler
reviewed
Apr 3, 2023
apiml-security-common/src/main/java/org/zowe/apiml/security/common/login/LoginRequest.java
Outdated
Show resolved
Hide resolved
JirkaAichler
reviewed
Apr 3, 2023
common-service-core/src/main/java/org/zowe/apiml/security/SecurityUtils.java
Outdated
Show resolved
Hide resolved
JirkaAichler
reviewed
Apr 3, 2023
caching-service/src/main/java/org/zowe/apiml/caching/service/redis/config/RedisConfig.java
Show resolved
Hide resolved
...ce/src/main/java/org/zowe/apiml/gateway/security/login/dummy/InMemoryUserDetailsService.java
Fixed
Show fixed
Hide fixed
...ce/src/main/java/org/zowe/apiml/gateway/security/login/dummy/InMemoryUserDetailsService.java
Fixed
Show fixed
Hide fixed
JirkaAichler
reviewed
Apr 3, 2023
...ervice/src/main/java/org/zowe/apiml/gateway/security/service/zosmf/AbstractZosmfService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
JirkaAichler
reviewed
Apr 3, 2023
...e/src/main/java/org/zowe/apiml/gateway/security/login/dummy/DummyAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
achmelo
reviewed
Apr 4, 2023
...ervice/src/main/java/org/zowe/apiml/gateway/security/service/zosmf/AbstractZosmfService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: achmelo <a.chmelo@gmail.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
JirkaAichler
reviewed
Apr 4, 2023
apiml-security-common/src/test/java/org/zowe/apiml/security/common/login/LoginFilterTest.java
Show resolved
Hide resolved
JirkaAichler
reviewed
Apr 4, 2023
.../test/java/org/zowe/apiml/integration/authentication/services/ZaasClientIntegrationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
…owe/api-layer into reboot/mitigateStoringPassword
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
…owe/api-layer into reboot/mitigateStoringPassword
pablocarle
changed the title
Mitigate storing password in the memory
fixMitigate storing password in the memory
Apr 5, 2023
pablocarle
changed the title
fixMitigate storing password in the memory
fix: mitigate storing password in the memory
Apr 5, 2023
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
15 tasks
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
pj892031
commented
Apr 12, 2023
apiml-security-common/src/test/java/org/zowe/apiml/security/common/login/LoginFilterTest.java
Outdated
Show resolved
Hide resolved
pj892031
commented
Apr 12, 2023
pj892031
commented
Apr 12, 2023
...ervice/src/main/java/org/zowe/apiml/gateway/security/service/zosmf/AbstractZosmfService.java
Outdated
Show resolved
Hide resolved
pj892031
commented
Apr 12, 2023
.../test/java/org/zowe/apiml/integration/authentication/services/ZaasClientIntegrationTest.java
Outdated
Show resolved
Hide resolved
pj892031
commented
Apr 12, 2023
zaas-client/src/main/java/org/zowe/apiml/zaasclient/service/internal/ZaasClientImpl.java
Outdated
Show resolved
Hide resolved
pj892031
commented
Apr 12, 2023
zaas-client/src/main/java/org/zowe/apiml/zaasclient/service/internal/ZaasClientImpl.java
Show resolved
Hide resolved
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Kudos, SonarCloud Quality Gate passed! |
JirkaAichler
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Java is a known issue that passwords stored as String are not under control. It can be minimized by using char arrays instead of String. It will not completely solve the issue, just reduce it a little bit. This PR changes the password stored as a string into array of chars where possible.
Type of change
Please delete options that are not relevant.
Checklist: