Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change ehCache storage location #3184

Merged
merged 9 commits into from
Nov 8, 2023
Merged

Conversation

taban03
Copy link
Contributor

@taban03 taban03 commented Nov 6, 2023

Fix cache storage location to use correct env variable to avoid resource lock when reading cache directory in HA setup.
Add conditional creation via configuration on CacheConfig bean since the old -Dnet.sf.ehcache.disabled=true property is not supported anymore in ehCache v3.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

…reation

Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Nov 7, 2023
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@pablocarle
Copy link
Contributor

I think we should have a small test to verify that the default has a spring context with the real cache implementation and not the NoOp

Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03 taban03 changed the title fix: change cache storage location and add conditional creation on cache controller fix: change cache storage location and add conditional creation on cacheconfig Nov 8, 2023
@taban03 taban03 changed the title fix: change cache storage location and add conditional creation on cacheconfig fix: change cache storage location and add conditional creation on CacheConfig Nov 8, 2023
@taban03 taban03 changed the title fix: change cache storage location and add conditional creation on CacheConfig fix: change cache storage location Nov 8, 2023
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 8, 2023
@taban03
Copy link
Contributor Author

taban03 commented Nov 8, 2023

I think we should have a small test to verify that the default has a spring context with the real cache implementation and not the NoOp

Added tests for both cache configs

Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@taban03 taban03 changed the title fix: change cache storage location fix: change ehCache storage location Nov 8, 2023
Copy link
Contributor

@pablocarle pablocarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@taban03 taban03 merged commit adfadff into v2.x.x Nov 8, 2023
30 of 31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/fix_ehcache_dir_location branch November 8, 2023 10:54
@pj892031 pj892031 mentioned this pull request Jan 17, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants