-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change ehCache storage location #3184
Conversation
…reation Signed-off-by: at670475 <andrea.tabone@broadcom.com>
gateway-service/src/main/java/org/zowe/apiml/gateway/controllers/CacheServiceController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
I think we should have a small test to verify that the default has a spring context with the real cache implementation and not the NoOp |
Added tests for both cache configs |
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Kudos, SonarCloud Quality Gate passed! 0 Bugs 100.0% Coverage The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Fix cache storage location to use correct env variable to avoid resource lock when reading cache directory in HA setup.
Add conditional creation via configuration on CacheConfig bean since the old
-Dnet.sf.ehcache.disabled=true
property is not supported anymore in ehCache v3.Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline