Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More general exception handling to detect TCP Stack restart #3462

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

pj892031
Copy link
Contributor

Description

It seems there are multiple implementations of handling server sockets and not all of them are detected just by error code inside the exception message.

This PR makes detection more general:

  • traverse over causes
  • check exception class
  • (as now) check the error code in the exception message

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com>
@pj892031 pj892031 changed the title fix: More More general exception handling to detect TCP Stack restartgeneral exception handling to detect TCP Stack restart fix: More general exception handling to detect TCP Stack restart Mar 12, 2024
@pj892031 pj892031 changed the base branch from v3.x.x to v2.x.x March 12, 2024 17:14
@pj892031 pj892031 marked this pull request as ready for review March 13, 2024 08:52
Copy link

sonarcloud bot commented Mar 18, 2024

@pj892031 pj892031 merged commit 33daf4c into v2.x.x Mar 18, 2024
30 of 31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/fix-tcp-stack-restart-condition branch March 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants