Fix link to custom metadata page #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for zowe-docs-master failed. 🔨 Explore the source changes: 1d9fb82 🔍 Inspect the deploy log: https://app.netlify.com/sites/zowe-docs-master/deploys/612f4991e5e5dc00076832ff |
nannanli
requested changes
Aug 31, 2021
There was a problem hiding this comment.
@janan07 The link looks good. For this custom metadata topic (custom-metadata.md), it's not in the sidebar so not avaibale for navigation now. Do you want to add it to the sidebar? https://github.com/zowe/docs-site/blob/rip/janan07/custom-metadata-link/sidebars.js
|
Hi Ashley,
Yes, I would like to add this in the sidebar. If I understand correctly, I
can add this as the following under Developing for API Mediation Layer:
"extend/extend-apiml/custom-metadata",
If this is correct, I will add this to this PR.
…On Tue, Aug 31, 2021 at 5:44 AM nannanli ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@janan07 <https://github.com/janan07> The link looks good. For this
custom metadata topic (custom-metadata.md), it's not in the sidebar so not
avaibale for navigation now. Do you want to add it to the sidebar?
https://github.com/zowe/docs-site/blob/rip/janan07/custom-metadata-link/sidebars.js
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1808 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJESEGYKUAJ7MEOYYVFOJXLT7RFZHANCNFSM5DB5744Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*Andrew Jandacek*
Technical Writer | Mainframe Software Division
Easytrieve, Pan/SQL, Telon, CA Brightside, Zowe API Mediation Layer
Broadcom
V Parku 2308/8 | Prague, 148 00 | Czech Republic
broadcom.com
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
|
Yes, that would be the best place to add this topic. : ) |
Signed-off-by: Andrew Jandacek <andrew.jandacek@broadcom.com>
|
I've added the path to sidebars.js.
…On Tue, Aug 31, 2021 at 11:55 AM nannanli ***@***.***> wrote:
Hi Ashley, Yes, I would like to add this in the sidebar. If I understand
correctly, I can add this as the following under Developing for API
Mediation Layer: "extend/extend-apiml/custom-metadata", If this is correct,
I will add this to this PR.
Yes, that would be the best place to add this topic. : )
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1808 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJESEG5QRB43XU24JTKZJ43T7SRKHANCNFSM5DB5744Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*Andrew Jandacek*
Technical Writer | Mainframe Software Division
Easytrieve, Pan/SQL, Telon, CA Brightside, Zowe API Mediation Layer
Broadcom
V Parku 2308/8 | Prague, 148 00 | Czech Republic
broadcom.com
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
|
Signed-off-by: nannanli <nannanli@cn.ibm.com>
|
Tested on local build and all is good. However, the netlify build failed with the following message. @idontknowjs Wondering if you have any insights into this issue? |
nannanli
approved these changes
Sep 2, 2021
|
@nannanli I deployed the same branch successfully on a diff URL. I've been trying to push some commits on this branch. Can you please look into this. I think I'm not having permission to push on |
@idontknowjs I've changed persimission. Give it another try. |
nannanli
added
area: apiml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Jandacek andrew.jandacek@broadcom.com
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.
If this PR relates to GitHub issues in
docs-siteor other repositories, please list in Description, prefixed with close, fix or resolve keywords.Description (including links to related git issues)
Please describe your pull request.
❤️Thank you!