Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Secure properties from non-existent files are not deleted #547

Closed
t1m0thyj opened this issue Feb 16, 2021 · 2 comments · Fixed by #968
Closed

Secure properties from non-existent files are not deleted #547

t1m0thyj opened this issue Feb 16, 2021 · 2 comments · Fixed by #968
Assignees
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have

Comments

@t1m0thyj
Copy link
Member

When the zowe config secure command is run to save secure properties for a config file, then properties from any other config files that are non-existent are removed from the properties object stored in the vault.

Is this desired behavior? What if a config file is on a network share that sometimes is unavailable?

@t1m0thyj t1m0thyj added question Further information is requested team-profile labels Feb 16, 2021
@awharn
Copy link
Member

awharn commented Feb 16, 2021

Something to consider: if a file was deleted, and we didn't remove secure properties for a non-existent file, when would those properties be removed from the credential vault?

It's a complicated situation, and there may need to be more thought on what the desired behavior is here, and how to handle the many different situations.

@zFernand0 zFernand0 added bug Something isn't working for-review To be reviewed in an Eng & Prod Mgmt meeting severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases and removed question Further information is requested team-profile labels Mar 7, 2023
@t1m0thyj t1m0thyj added enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have and removed bug Something isn't working severity-high Bug for which there may be workaround but limits the usage of the Zowe for major use cases labels Mar 27, 2023
@t1m0thyj t1m0thyj changed the title Secure properties from non-existent files get deleted Secure properties from non-existent files are not deleted Mar 27, 2023
@t1m0thyj
Copy link
Member Author

t1m0thyj commented Mar 27, 2023

Updated issue title to reflect current behavior - secure properties from non-existent config files are not deleted.

I think this is a low priority issue for now since no one has complained, but in the future we may need to pick an approach:

  • When updating secure properties in the vault, remove properties for config files that no longer exist. This could cause problems if some paths on the file system exist intermittently like mounted network shares.
  • Offer a separate command to prune secure properties. Otherwise, the current behavior leads to storing a JSON object that will continually grow in size every time someone creates a new config file and never shrinks.
    • Perhaps adding a --prune option to the zowe config secure command would make more sense than a separate command - thanks @gejohnston for the idea 🙂

@JTonda JTonda removed the for-review To be reviewed in an Eng & Prod Mgmt meeting label Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants