Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to disable validation of profiles setting #922

Closed
zdmullen opened this issue Jul 2, 2020 · 4 comments · Fixed by #979
Closed

Provide ability to disable validation of profiles setting #922

zdmullen opened this issue Jul 2, 2020 · 4 comments · Fixed by #979
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@zdmullen
Copy link
Contributor

zdmullen commented Jul 2, 2020

Is your feature request related to a problem? Please describe.

This is the more involved fix for Pete's issue, #918.

Describe the solution you'd like

As a user, I would like to be able to disable the validation of profiles setting since I may be working with cloud instances (zD&Ts) or particularly slow LPARS that make this process long and unnecessary.

Describe alternatives you've considered

Previous to this, users will be notified of the process occurring (issue #921)

@JillieBeanSim
Copy link
Contributor

JillieBeanSim commented Aug 4, 2020

Here is the flow I would like and screen shots of what I have so far. The only problem I am having at the moment deals with the bottom block/scenario where the user has Disabled/Enabled via a right click action and should get the alternate option the next time they right click on the session/profile. The regex I have for when at this moment only reads the global setting of true or false, I am not familiar with regex and am not sure how to go about checking the profile's validation setting which is stored in a new validation variable in the IProfileLoaded. Help with the regex and feedback on the flow is appreciated.

image

@JillieBeanSim
Copy link
Contributor

wanted to show an update here. I have the regex working for the right click action (bottom block on the chart above) in the USS tree. So now just to implement this in the other trees and add new unit test to cover new code.
Validation-right-click

@jellypuno
Copy link
Contributor

Cool! Thank you @JillieBeanSim for this. Question, I have the Global Validation checked. If I disable the validation for Profile A and then close VSC, will the Global Validation take effect once I open VSCode? or ZE can detect that I have disabled the validation in Profile A before?

@JillieBeanSim
Copy link
Contributor

JillieBeanSim commented Aug 11, 2020

Cool! Thank you @JillieBeanSim for this. Question, I have the Global Validation checked. If I disable the validation for Profile A and then close VSC, will the Global Validation take effect once I open VSCode? or ZE can detect that I have disabled the validation in Profile A before?

@jellypuno upon refresh or restart of vs code all profiles will revert back to global setting. Refreshing of a tree view will keep the alternate setting. Should refreshing a tree view revert back to global setting as well? What do you think?

zFernand0 added a commit that referenced this issue Sep 9, 2020
Issue #922 Ability to Disable Profile Validation (only codecov/project failing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants