Remove validation check before updating profile

[JillieBeanSim]

Signed-off-by: Billie Simmons 49491949+JillieBeanSim@users.noreply.github.com

Proposed changes

Bug Fix: Remove validation check before updating profile, then after updating the profile it is revalidated and the icon is updated.

Release Notes

Milestone: 1.18.0

Changelog: Bug Fix: Remove validation check before updating profile.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[jellypuno]

Thanks @JillieBeanSim ! This is the fix that I've come up with as well. The only thing I notice is that if the profile is already validated and then you updated the host/port then you have to do a search before it is validated again. But I think it is not a problem

[JillieBeanSim]

Thanks @JillieBeanSim ! This is the fix that I've come up with as well. The only thing I notice is that if the profile is already validated and then you updated the host/port then you have to do a search before it is validated again. But I think it is not a problem

Hey @jellypuno I thought of that too. What we could do is run the validation check at the end of the method vs waiting for search or other action that would kick off validation.

[jellypuno]

Works great! @JillieBeanSim