fix: remove instances of slashes in path.join calls #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
t1m0thyj,
zFernand0,
JillieBeanSim,
rudyflores and
traeok
t1m0thyj
approved these changes
May 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
zFernand0
approved these changes
May 26, 2023
| @@ -1057,7 +1057,7 @@ describe("Extension Integration Tests - USS", () => { | |||
| const sessChildren2 = await ussTestTree.getChildren(sessChildren1[3]); | |||
| sessChildren2[2].dirty = true; | |||
| const dirChildren = await ussTestTree.getChildren(sessChildren2[2]); | |||
| const localPath = path.join(globals.USS_DIR, "/", testConst.profile.name, dirChildren[0].fullPath); | |||
| const localPath = path.join(globals.USS_DIR, testConst.profile.name, dirChildren[0].fullPath || ""); | |||
There was a problem hiding this comment.
I'm curious if there's any difference between ?? "" and || "".
I've seen we use them interchangeably, so it's probably fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #2172 by removing
/characters inpath.join()calls.Release Notes
Milestone: v2.9.0
Changelog: Removed "/" characters in path.join() calls.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments