Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress indicator should spin when file is being retrieved #318

Open
John-A-Davies opened this issue Nov 9, 2018 · 2 comments
Open

Progress indicator should spin when file is being retrieved #318

John-A-Davies opened this issue Nov 9, 2018 · 2 comments
Assignees

Comments

@John-A-Davies
Copy link

In the unix file explorer, the circular arrow does not spin when it's fetching the file. So the user thinks his click did nothing.

@jordanCain jordanCain removed their assignment Jan 22, 2019
@jordanCain jordanCain transferred this issue from zowe/explorer-uss Nov 8, 2019
@NakulManchanda NakulManchanda added the good first issue Good for newcomers label Jul 13, 2020
@Martin-Zeithaml
Copy link

Hi,
I would like to work on this, I started looking into the code, but I will need some help.
As far as I know, the refresh icon is controlled by isFetching state.
The last action when getting file is RECEIVE_CONTENT, I suppose I need to add/change the isFetching for this type of action.
Am I correct? Thanks for any advices.

@skurnevich
Copy link

Hi @Martin-Zeithaml,
Yes, you are looking in the right direction, but as I see, the RECEIVE_CONTENT action is fired when everything is ready, so at this moment we should turn off the spinning (set isFetching: false) so you should look for the REQUEST_CONTENT action that starts the fetching.

You need to add handling of REQUEST_CONTENT action to the editor reducer and turn on fetching there, and then set it to false in RECEIVE_CONTENT and also to the INVALIDATE_CONTENT in case the fetching will fail.

And then you need to map this isFetching to the USSTree state.
You can see how it is done for MVS explorer with two isFetching props (isFetchingTree and isFetchingDatasets) here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

5 participants