Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Refresh button does not pick up extenders' profile updates #1078

Closed
lauren-li opened this issue Nov 19, 2020 · 0 comments · Fixed by #1089
Closed

Tree Refresh button does not pick up extenders' profile updates #1078

lauren-li opened this issue Nov 19, 2020 · 0 comments · Fixed by #1089
Assignees
Labels
bug Something isn't working

Comments

@lauren-li
Copy link
Contributor

lauren-li commented Nov 19, 2020

Describe the bug

If an extender's profile yaml is edited outside of Zowe Explorer (e.g. via CLI or manually by the user), clicking the Zowe Explorer Refresh button for a tree does not pick up the change. Clicking the Refresh button will only update externally-edited z/OSMF profiles because profile types are not passed into Profiles.getInstance().getProfiles() when it is called in refreshTree, and "zosmf" is the default argument for this function.

Proposed solution: Pass in profile type as an argument to Profiles.getInstance().getProfiles() in the refreshTree function. Note that profile type is already a parameter for Profiles.getInstance().getProfiles() in the master branch code, but we just need to use it.

To Reproduce

  1. Be sure the extender's profile is added in the Data Sets tree view. (This issue happens for any tree view, but I am just using the Data Sets view for simplicity here.)
  2. Edit the extender's profile information via CLI, or by editing the profile's yaml file directly. For example, change the profile's port number.
  3. Click the Refresh arrow button in the Data Sets view.
  4. Click on the "Edit" icon for profile, and see that the profile's information (e.g. port number) was not changed.

Expected behavior

When the user clicks a tree's Refresh button, profile information for all profile types (i.e. z/OSMF and extenders) should be updated.

Desktop (please complete the following information):

  • OS: N/A
  • Zowe Explorer Version: 1.10.1
  • (Optional) Zowe CLI Version: 6.22.0
  • (Optional) Are you using Secure Credential Store? Issue happens both with and without SCS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant