Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP extension creating files that shouldn't be tracked running tests #1594

Closed
JillieBeanSim opened this issue Nov 29, 2021 · 3 comments · Fixed by #1596
Closed

FTP extension creating files that shouldn't be tracked running tests #1594

JillieBeanSim opened this issue Nov 29, 2021 · 3 comments · Fixed by #1596
Assignees
@JillieBeanSim
Labels
bug Something isn't working priority-high Production outage - this quarter or at least next quarter

Comments

@JillieBeanSim
Copy link
Contributor

Describe the bug

I didn't see this until I was on a different branch and ran the tests after #1582 was merged.

image

To Reproduce

Expected behavior

these files should be ignored

Screenshots

Desktop (please complete the following information):

  • OS:
  • Zowe Explorer Version:
  • (Optional) Zowe CLI Version:
  • (Optional) Are you using Secure Credential Store?

Additional context
@JillieBeanSim JillieBeanSim added the bug Something isn't working label Nov 29, 2021
@github-actions
Copy link

Thank you for creating a bug report. If you haven't already, please ensure you have provided steps to reproduce it and as much context as possible.

@JillieBeanSim JillieBeanSim added the priority-high Production outage - this quarter or at least next quarter label Nov 29, 2021
@JillieBeanSim JillieBeanSim linked a pull request Nov 29, 2021 that will close this issue
Move FTP unit test results to be ignored by source control #1596
Merged
16 tasks
@tiantn
Copy link
Contributor

tiantn commented Nov 30, 2021

Thanks @JillieBeanSim ! I will put the coverage file in .gitigore. Thank you! 😊

@JillieBeanSim
Copy link
Contributor Author

@tiantn I have a PR for this fix #1596, would you mind reviewing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JillieBeanSim JillieBeanSim

Labels
bug Something isn't working priority-high Production outage - this quarter or at least next quarter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move FTP unit test results to be ignored by source control zowe/zowe-explorer-vscode
2 participants
@tiantn @JillieBeanSim