Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyring module in @zowe/secrets-for-zowe-sdk as replacement for node-keytar #2358

Closed
26 tasks done
traeok opened this issue Jun 27, 2023 · 1 comment · Fixed by #2405
Closed
26 tasks done

Use keyring module in @zowe/secrets-for-zowe-sdk as replacement for node-keytar #2358

traeok opened this issue Jun 27, 2023 · 1 comment · Fixed by #2405
Assignees
Labels
enhancement New feature or request Security
Milestone

Comments

@traeok
Copy link
Member

traeok commented Jun 27, 2023

This issue refers to the R&D for using keytar-rs in place of node-keytar as node-keytar is no longer maintained.

Update: keytar-rs is now the keyring module in @zowe/secrets-for-zowe-sdk: see here.

Action items:

  • Research electron-rebuild for preparing keytar-rs for Electron environments (might not be needed)
  • Incorporate keytar-rs in imperative and CLI: see keytar-rs branch for updates
    • Implementation
    • Fix unit tests in CLI and imperative
    • Fix integration tests in imperative
    • Merge into codebase as "secrets SDK"
      • Update CLI repo w/ secrets SDK package
        • Adjust workflows to build secrets SDK on-demand
        • Wait for reviews; merge and publish once complete
      • Update imperative w/ secrets SDK
      • Update ZE w/ secrets SDK
  • Investigate use of keytar-rs in Zowe Explorer: see keytar-rs branch for updates
  • Test keytar-rs usage in CLI and Zowe Explorer; verify that credential management still works as-is
    • zowe config secure --gc to update/store user credentials in the CLI
      • Windows
      • macOS
      • Linux
    • setPassword in local environment (using "Update Credentials")
      • Windows
      • macOS
      • Linux
    • setPassword in remote environment (using "Update Credentials")
      • Remote SSH to WSL
      • Remote SSH to headless Linux
      • Remote SSH in misc. environments
      • Theia
@traeok traeok self-assigned this Jun 27, 2023
@github-actions
Copy link

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 10 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@traeok traeok changed the title Spike: Experiment using keytar-rs as drop-in replacement for node-keytar Use keytar-rs as drop-in replacement for node-keytar Jul 20, 2023
@traeok traeok changed the title Use keytar-rs as drop-in replacement for node-keytar Use keyring module in @zowe/secrets-for-zowe-sdk as replacement for node-keytar Aug 1, 2023
@JillieBeanSim JillieBeanSim added this to the v2.10.0 milestone Aug 23, 2023
@traeok traeok mentioned this issue Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Security
Projects
None yet
2 participants