Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with firefox 57+ #13

Open
vincekd opened this issue Aug 10, 2017 · 10 comments
Open

Make compatible with firefox 57+ #13

vincekd opened this issue Aug 10, 2017 · 10 comments

Comments

@vincekd
Copy link

vincekd commented Aug 10, 2017

Currently it's marked as legacy and will be disabled on nightly and next month on beta.

@ghost
Copy link

ghost commented Sep 28, 2017

I second this request, AlwaysAsk is currently my last extension which hasn't been updated to support 57+. I just hope the functionality can be preserved with the new extension limitations.

@kquinsland
Copy link

+1 from me as well. Paging @zpao for clarification; is this abandon ware?

@zpao
Copy link
Owner

zpao commented Nov 16, 2017

It's not abandonware but it is open source.

I haven't had any time to see how possible this is with the extensions API. Hopefully soon but can't make any promises.

@zpao
Copy link
Owner

zpao commented Nov 16, 2017

nsIObserverService, which was the main way this worked, is no longer accessible. Nor can I read prefs (or prompt?). Maybe it's still possible to get something with some of the functionality but I'm not hopeful.

@coderanger
Copy link

@zpao Indeed :( The closest you can get with WebExt is to override the ctrl+q and cmd+q key sequences. You can either leave them permanently disabled (a la https://addons.mozilla.org/en-US/firefox/addon/disable-ctrl-q-and-cmd-q/) or I've seen some people trying to work out ways to copy the Chrome style "press twice within 5 seconds to really quit" (though the prototype was very broken, but could be fixed) by using timers to attach and detach the keyboard shortcut.

@kquinsland
Copy link

@zpao No worries! The last time i did any major JS development, jQuery was just beginning to take root... so i dont think you want me opening any PR's :).

also, from what @coderanger was saying, it sounds like there's work that needs to be done on the mozilla API side before a good solution can be implemented...

@vincekd
Copy link
Author

vincekd commented Nov 18, 2017 via email

@coderanger
Copy link

There is actually an about:config item for this, it just hasn’t worked in a long time.

@vincekd
Copy link
Author

vincekd commented Nov 18, 2017 via email

@zpao
Copy link
Owner

zpao commented Nov 19, 2017

@vincekd Yea, I tried to write this inside Firefox once, am CCed on that bug (though not reading bugmail). https://bugzilla.mozilla.org/show_bug.cgi?id=565567 for those interested. I think it might get some renewed interest now that it's not possible for extensions to handle this.

@coderanger Yea, I used to work on all of this code inside Firefox. The complicated mess of settings and exact conditions to trigger a prompt is part of why I made this in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants