Skip to content

Commit

Permalink
Move Page.tap() to FrameBase
Browse files Browse the repository at this point in the history
Turns out you can tap in a frame too.
  • Loading branch information
zploskey committed Jun 8, 2018
1 parent 7cc7478 commit ee135af
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 3 additions & 0 deletions src/FrameBase.re
Expand Up @@ -418,3 +418,6 @@ external hover : (~selector: string) => Js.Promise.t(unit) = "";
external select : external select :
(~selector: string, ~values: array(string)) => Js.Promise.t(array(string)) = (~selector: string, ~values: array(string)) => Js.Promise.t(array(string)) =
""; "";

[@bs.send.pipe: t]
external tap : (~selector: string) => Js.Promise.t(unit) = "";
3 changes: 0 additions & 3 deletions src/Page.re
Expand Up @@ -310,9 +310,6 @@ let setBypassCSP = (~enabled, page) => setBypassCSP(page, ~enabled);
[@bs.send.pipe: t] [@bs.send.pipe: t]
external setViewport : (~viewport: viewport) => Js.Promise.t(unit) = ""; external setViewport : (~viewport: viewport) => Js.Promise.t(unit) = "";


[@bs.send.pipe: t]
external tap : (~selector: string) => Js.Promise.t(unit) = "";

[@bs.send] external target : t => Types.target = ""; [@bs.send] external target : t => Types.target = "";


[@bs.send] external title : t => Js.Promise.t(string) = ""; [@bs.send] external title : t => Js.Promise.t(string) = "";
Expand Down

0 comments on commit ee135af

Please sign in to comment.