Add environment variable #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may want to describe your change in the readme as well: https://github.com/zplug/zplug#4-environment-variables-for-zplug |
|
What does this change bring? Why is it necessary? |
babarot
requested changes
Dec 22, 2016
| @@ -95,6 +95,7 @@ __zplug::core::core::prepare() | |||
| # Add to the PATH | |||
| path=( | |||
| ${ZPLUG_ROOT:+"$ZPLUG_ROOT/bin"} | |||
| ${ZPLUG_HOME:+"$ZPLUG_BIN"} | |||
There was a problem hiding this comment.
Whether merged or not, the code here seems to be wrong.
babarot
requested changes
Jan 10, 2017
| @@ -362,6 +362,10 @@ source ~/.zshrc_secret | |||
| zplug "some/command", hook-build:"make && sudo make install" | |||
| ``` | |||
|
|
|||
| #### `ZPLUG_BIN` | |||
|
|
|||
| Defaults to `$ZPLUG_BIN`. You can change the save destination of the command's symbol link, eg `~/bin`. | |||
| @@ -362,6 +362,10 @@ source ~/.zshrc_secret | |||
| zplug "some/command", hook-build:"make && sudo make install" | |||
| ``` | |||
|
|
|||
| #### `ZPLUG_BIN` | |||
|
|
|||
| デフォルトは `$ZPLUG_HOME/bin`。コマンドのシンボルリンクの保存先を変更することができる。例えば `~/bin` とか。 | |||
babarot
requested changes
Jan 12, 2017
|
I already did rebase, but did you have any inadequacies? |
|
Looks like he wants one commit from you ("add $ZPLUG_BIN variable"), not 4. |
|
Apparently I seem to have misunderstood. @Defman21: Thank you |
babarot
requested changes
Jan 13, 2017
| @@ -356,6 +356,10 @@ source ~/.zshrc_secret | |||
| zplug "some/command", hook-build:"make && sudo make install" | |||
| ``` | |||
|
|
|||
| #### `ZPLUG_BIN` | |||
|
|
|||
| Defaults to `$ZPLUG_BIN`. You can change the save destination of the command's symbolic link, e.g. `~/bin`. | |||
There was a problem hiding this comment.
You mean: Defaults to $ZPLUG_HOME/bin
babarot
approved these changes
Jan 23, 2017
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
$ZPLUG_BIN.