Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printf in __zplug::job::handle::wait #430

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Conversation

kba
Copy link
Contributor

@kba kba commented Aug 1, 2017

Since arguments to __zplug::io::print::f are two integers, do not prepend [zplug]. Also, use the proc_states associative array for length, not the array repos.

Without these changes, I get output like this:

[zplug] Start to [zplug] update printf: [zplug] 10: expected a numeric value
0 plugins [zplug] in parallel

 ⠙  Updating...           zsh-users/zsh-completions
 ⠹  Updating...           zsh-users/zsh-completions-completion
 ⠸  Updating...           zsh-users/zsh-completions-completion
 ⠼  Updating...           zsh-users/zsh-completions-completionch
[...]

[zplug] Finished: printf: [zplug] 0: expected a numeric value
0/printf: [zplug] 10: expected a numeric value
0 plugins

@kba kba changed the title 🐛 Fix printf in __zplug::job::handle::wait Fix printf in __zplug::job::handle::wait Aug 1, 2017
@kba
Copy link
Contributor Author

kba commented Sep 6, 2017

Sorry to bump, but I've run into this on every (linux) box I deployed my zsh-config to. Is nobody else having this issue?

Edit: Seems like the same issue as #419

@babarot
Copy link
Member

babarot commented Oct 13, 2017

LGTM

@sudoforge
Copy link

Is there any particular reason that this hasn't been merged?

@kba
Copy link
Contributor Author

kba commented Dec 2, 2017

Sorry to bump yet again but I run into this consistently.

@kba
Copy link
Contributor Author

kba commented Jan 3, 2018

@b4b4r07 Sorry, another bump, since you released a new version last week. Please consider including this PR in the next release, it still happens for me on Ubuntu 17.10

@ghost
Copy link

ghost commented Feb 15, 2018

LGTM
@b4b4r07 @NigoroJr @39e これはいつマージされますか?

@babarot babarot merged commit 335536a into zplug:master Feb 15, 2018
@babarot
Copy link
Member

babarot commented Feb 15, 2018

Hi, all. Sorry for late response. I merged this PR now. Sorry for inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants