Allows for base classing of Element types #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignores types that are of type PublishedElementModel when applying a custom base class attribute
|
Partially fixes issue #205 Still needs ability to create custom base class for Elements. |
Adds the ability to create a Element base class
|
This now also allows for base classing of Elements. However still needs a Unit Test. |
pgregorynz
changed the title
|
Currently reviewing + testing. In ParseResult.cs you have two new things, Other than that, it looks good, although I might merge with a few adaptations. |
|
Am going to close the PR - it has been merged, kinda - used for inspiration + stealing code, but could not merge it directly. Thanks anyways! Keeping issue #205 open for discussion etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores types that are of type PublishedElementModel when applying a custom base class attribute.
Could be improved allow for a custom base class element types also