Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Flatness epsilon for single precision compute #120

Open
zpzim opened this issue Aug 20, 2022 · 0 comments
Open

Adjust Flatness epsilon for single precision compute #120

zpzim opened this issue Aug 20, 2022 · 0 comments
Labels
enhancement New feature or request performance

Comments

@zpzim
Copy link
Owner

zpzim commented Aug 20, 2022

The flatness epsilon is currently hardcoded to 1e-13. For single precision computation, we should set this to a much larger value like 1e-5 or something so that we produce more accurate results.

Will need to do some testing to evaluate options. Perhaps we can make this epsilon configurable as an input option.

@zpzim zpzim added enhancement New feature or request performance labels Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

1 participant