Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyscamp GPU output is incorrect in some cases since version 2.1.0 #82

Closed
zpzim opened this issue Feb 6, 2022 · 2 comments · Fixed by #83
Closed

pyscamp GPU output is incorrect in some cases since version 2.1.0 #82

zpzim opened this issue Feb 6, 2022 · 2 comments · Fixed by #83
Assignees
@zpzim
Labels
bug Something isn't working

Comments

@zpzim
Copy link
Owner

zpzim commented Feb 6, 2022

There is an issue with the SCAMP interface which causes additional threads to target GPU 0, which introduces a race condition which can cause incorrect output. Fix is incoming.
@zpzim zpzim added the bug Something isn't working label Feb 6, 2022
@zpzim zpzim self-assigned this Feb 6, 2022
@zpzim zpzim linked a pull request Feb 6, 2022 that will close this issue
Prevent accidental generation additional gpu threads when using pyscamp #83
Merged
@zpzim
Copy link
Owner Author

zpzim commented Feb 6, 2022

Note that once PR #81 is merged and we have GPU integration tests this kind of issue will be caught automatically.

@zpzim zpzim closed this as completed in #83 Feb 6, 2022
@zpzim
Copy link
Owner Author

zpzim commented Feb 6, 2022

Leaving this open until I can cut a new release.

@zpzim zpzim reopened this Feb 6, 2022
@zpzim zpzim closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpzim zpzim

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent accidental generation additional gpu threads when using pyscamp zpzim/SCAMP
1 participant
@zpzim