Fix closing file in writeJson and writeSarif (#1187)

gitleaks · Jun 5, 2023 · 190ac97 · 190ac97
1 parent 6dbb0c5
commit 190ac97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/report/json.go b/report/json.go
@@ -9,6 +9,8 @@ func writeJson(findings []Finding, w io.WriteCloser) error {
 	if len(findings) == 0 {
 		findings = []Finding{}
 	}
+	defer w.Close()
+
 	encoder := json.NewEncoder(w)
 	encoder.SetIndent("", " ")
 	return encoder.Encode(findings)

diff --git a/report/sarif.go b/report/sarif.go
@@ -14,6 +14,7 @@ func writeSarif(cfg config.Config, findings []Finding, w io.WriteCloser) error {
 		Version: "2.1.0",
 		Runs:    getRuns(cfg, findings),
 	}
+	defer w.Close()
 
 	encoder := json.NewEncoder(w)
 	encoder.SetIndent("", " ")