-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --max-target-megabytes : maximum size for a file/blob to be scanned #1003
Conversation
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. All security workflows are defined in a centralized repository named .jit. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
README.md
Outdated
@@ -160,6 +160,7 @@ Flags: | |||
-b, --baseline-path path to a previously generated report with known issues that gitleaks should ignore | |||
-s, --source string path to source (git repo, directory, file) | |||
-v, --verbose show verbose output from scan | |||
--max-target-megabytes maximum size for a file/blob to be scanned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding something like "Files larger than this will be skipped". Just to be totally explicit about the behavior.
Sure np will add Files larger than this will be skipped to read me as u mention. ty for your feedback |
@weineran any chance u can check the PR, i adjust the push according to your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roma8389 did some local testing of this feature and it seems to be working great! I think this is a really useful feature. Thanks for the PR. This will go into the next release. Just need to update one "help" message then this is good to go.
Per #1001
i was wonder if it possible to get a CLI switch where i will add timeout pre rule
I think this is also a worthwhile feature to introduce FWIW
Description:
Adding maximum size for a file/blob to be scanned via a new switch case in the CLI --max-target-megabytes
Checklist: