Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define log-opts, odd that this wasn't failing before... #1009

Merged
merged 1 commit into from
Oct 11, 2022
Merged

define log-opts, odd that this wasn't failing before... #1009

merged 1 commit into from
Oct 11, 2022

Conversation

zricethezav
Copy link
Collaborator

Description:

Fixes #1007

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@zricethezav zricethezav mentioned this pull request Oct 11, 2022
Closed
@zricethezav zricethezav merged commit c39e764 into master Oct 11, 2022
@zricethezav zricethezav deleted the fix-protect-log-opts branch October 11, 2022 12:11
@electriquo
Copy link
Contributor

@zricethezav in the spirit of this pull-request. Is there anyway to have the workflows/tests fail?

@zricethezav
Copy link
Collaborator Author

@foolioo tests could definitely be added for the cmd package. However, it's not on top of my priorities since this is a free-time project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FTL error="flag accessed but not defined: log-opts"
2 participants
@zricethezav @electriquo