Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore package-lock.json #1076

Merged
merged 2 commits into from Feb 25, 2023
Merged

ignore package-lock.json #1076

merged 2 commits into from Feb 25, 2023

Conversation

lawndoc
Copy link
Contributor

@lawndoc lawndoc commented Jan 13, 2023

package-lock.json is automatically generated by npm and can cause a lot of false positives. There should never be secrets in the file because it just lists dependencies and is usually never edited by humans.

`package-lock.json` is automatically generated by npm
@jit-ci
Copy link

jit-ci bot commented Jan 13, 2023

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

All security workflows are defined in a centralized repository named .jit.
In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@zricethezav
Copy link
Collaborator

@lawndoc thanks for the PR! Could you add this to the config template here https://github.com/zricethezav/gitleaks/blob/master/cmd/generate/config/rules/config.tmpl#L13-L21?

@lawndoc
Copy link
Contributor Author

lawndoc commented Jan 22, 2023

@zricethezav done :)

@lawndoc
Copy link
Contributor Author

lawndoc commented Feb 23, 2023

@zricethezav anything else missing or is this good to merge?

Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems reasonable 👍

@zricethezav zricethezav merged commit 343e693 into gitleaks:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants