Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicPayment: Bonus/Penalty not updated when player leaves job #1717

Closed
TheDiscordian opened this issue Feb 8, 2024 · 1 comment
Closed

Comments

@TheDiscordian
Copy link

TheDiscordian commented Feb 8, 2024

Detailed description of the issue:

There's a bug in DynamicPayment. If a player joins a job the bonus/penalty is updated, but if they leave the job it isn't.

Let's say there are 2 people online with different jobs (let's say 1 miner, 1 explorer). Both will have +0% bonus. However if one player stops exploring and starts the miner job, the penalty goes to 50%. So far so good. However if that player then stops mining and goes back to exploring, the explorer has +0% (correct) and the miner now has a -50% penalty (incorrect). This is fixed by the miner leaving the mining job and rejoining it, but it's very annoying.

CONFIG SECTION:

    equation: totalworkers / jobstotalplayers - 2
    MaxPenalty: 50.0
    MaxBonus: 50.0

Jobs version: v5.2.2.3

Server Type (Spigot/Paper/etc): Paper

Server Version (using /ver): Paper version git-Paper-408 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: c5d168c)

@Zrips
Copy link
Owner

Zrips commented Apr 16, 2024

746c431

@Zrips Zrips closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants