-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculation wrong #4
Comments
I've verified the calculation is correct here: I read the linked resource when creating this library. Does something specific exist in the paper which refutes the accuracy of the implementation? (By the way, de00 gives inaccurate results when there is a hue shift of 180/360 degrees. this is mentioned in the paper) |
I just noticed in your original message you said the difference in color is extremely small. Are you using the CIELAB color space? The colors are drastically different. Bright green vs bright pink. You can also tell the colors are polar opposites in hue because the colors are inverted in A/B values. |
Well, I fed all the test data in that paper through this function and it looks like the results are the same. Also, the paper only tests colors with a very small color difference (R<2.5) so the discontinuity is small there. But as you can see above, the discontinuity is huge. That said, DeltaE is apparently just really bad at diffing colors where dE>5 or so. So, From the paper:
|
Momma always said nothing was perfect 😉 Reviewing this, it would be cool if discontinuity was calculated. Too specific of a use case and time consuming for it to be a good addition I think. Cheers! |
This Delta E calculation is wrong. For some insight I suggest reading this paper.
Details:
How can that be right when the difference in the second color is extremely small (and no difference in the first color) but the resulting Delta E is radically different?
The text was updated successfully, but these errors were encountered: