Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player APM doesn't fit in display box #9

Closed
zsol opened this issue Feb 8, 2011 · 6 comments
Closed

Player APM doesn't fit in display box #9

zsol opened this issue Feb 8, 2011 · 6 comments
Labels

Comments

@zsol
Copy link
Owner

zsol commented Feb 8, 2011

When player's name is too long, the APM gets chopped and it doesn't display.
See http://cupapp.dyndns.info/en/replay/view/7/1v1-Lost_Temple-LiquidHuK-IMJunwiPirme for an example

@eshton
Copy link
Collaborator

eshton commented Feb 8, 2011

We have to investigate the maximum length of the player's name and set the size of that box so it will fit in all the time. I think the icon should be smaller as well.

@zsol
Copy link
Owner Author

zsol commented Feb 14, 2011

The max length of an SC2 nickname is 12 characters currently.
I'd say let's make it 200px wide, so the left panel would be 360px then. Agree?
I'll upload even smaller icons soon

@eshton
Copy link
Collaborator

eshton commented Feb 15, 2011

I believe is you just make the icon smaller then it will resolve this problem. Also, the example disappeared :D

@zsol
Copy link
Owner Author

zsol commented Feb 15, 2011

The example is here: http://test.cupapp.com/en/replay/view/7/1v1-Lost_Temple-LiquidHuK-IMJunwiPirme

I have set the players panel to 200px and made the icons smaller. I still think it's possible for player names to be too long (i.e. "MMMMMMMMMMMM" would probably not fit), but I have also noticed that giving a really long description for a replay also screws up the layout so we might have to come up with a more dynamic one. Example: http://test.cupapp.com/en/replay/view/12/Nemtudni-Metalopolis-Flint-Zsol-sHadowLigHt-Stylosa

@eshton
Copy link
Collaborator

eshton commented Feb 15, 2011

Put the description field in a paragraph tag and add the next styles:
width: 260px;
word-wrap: break-word;

@zsol
Copy link
Owner Author

zsol commented Feb 21, 2011

this is now fixed in the latest commit

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants