-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player APM doesn't fit in display box #9
Comments
We have to investigate the maximum length of the player's name and set the size of that box so it will fit in all the time. I think the icon should be smaller as well. |
The max length of an SC2 nickname is 12 characters currently. |
I believe is you just make the icon smaller then it will resolve this problem. Also, the example disappeared :D |
The example is here: http://test.cupapp.com/en/replay/view/7/1v1-Lost_Temple-LiquidHuK-IMJunwiPirme I have set the players panel to 200px and made the icons smaller. I still think it's possible for player names to be too long (i.e. "MMMMMMMMMMMM" would probably not fit), but I have also noticed that giving a really long description for a replay also screws up the layout so we might have to come up with a more dynamic one. Example: http://test.cupapp.com/en/replay/view/12/Nemtudni-Metalopolis-Flint-Zsol-sHadowLigHt-Stylosa |
Put the description field in a paragraph tag and add the next styles: |
this is now fixed in the latest commit |
When player's name is too long, the APM gets chopped and it doesn't display.
See http://cupapp.dyndns.info/en/replay/view/7/1v1-Lost_Temple-LiquidHuK-IMJunwiPirme for an example
The text was updated successfully, but these errors were encountered: